Conversation
|
Opened this PR for the initial review. |
|
Thanks for the patch! I think it would be a good idea to mention that this function does not decrement the reference count. For the example it would be very nice to not have to create an |
Add the function `into_raw` to `ARef<T>`. This method can be used to turn an `ARef` into a raw pointer. Signed-off-by: Kartik Prajapati <kartikprajapati987@gmail.com>
9dad66b to
10cef0c
Compare
|
Thanks for checking the patch @y86-dev!
I've added this as a note in doc comment.
In |
|
Everything for upstream goes through the mailing list -- please see https://rust-for-linux.com/contributing#the-kernel-development-process. While |
To send a patch on top of another patch series, do I need to do anything apart from mentioning dependent patch in commit message as described in this doc? |
|
That would be enough, yeah (below the Thanks! |
|
@ojeda this patch when upstream? or I can take to push it to the finish line? |
|
I don't think it was sent to the mailing list. |
|
@Kartik1397 Do you plan to send this to the mailing list, or would you prefer that @vincenzopalazzo sends it on your behalf? (you would still be mentioned as author or co-author) Thanks! |
|
@ojeda I wouldn't be able to work on this for at least two more weeks as I'm currently engaged in another project. Thanks! |
Sending a v2 that is merged with [1]. I didn't realize that I was duplicating work, sorry! I'll update the author information to list Kartik as the primary author. I kept my function body so that it returns NonNull to mirror the type used by `ARef::from_raw`. This change was previously included in https://lore.kernel.org/all/20240801-vma-v3-1-db6c1c0afda9@google.com/ but is being split out in its own commit at Danilo's suggestion. To: Miguel Ojeda <ojeda@kernel.org> Cc: Alex Gaynor <alex.gaynor@gmail.com> Cc: Wedson Almeida Filho <wedsonaf@gmail.com> Cc: Boqun Feng <boqun.feng@gmail.com> Cc: Gary Guo <gary@garyguo.net> Cc: Björn Roy Baron <bjorn3_gh@protonmail.com> Cc: Benno Lossin <benno.lossin@proton.me> Cc: Andreas Hindborg <a.hindborg@samsung.com> Cc: Andreas Hindborg <a.hindborg@samsung.com> Cc: rust-for-linux@vger.kernel.org Cc: linux-kernel@vger.kernel.org Link: Rust-for-Linux#1056 [1] Signed-off-by: Alice Ryhl <aliceryhl@google.com> --- Changes in v2: - Add example from [1], and fix the imports in the example so it compiles. - Update author information to reflect merge with [1]. - Link to v1: https://lore.kernel.org/r/20240801-aref-into-raw-v1-1-33401e2fbac8@google.com --- b4-submit-tracking --- # This section is used internally by b4 prep for tracking purposes. { "series": { "revision": 2, "change-id": "20240801-aref-into-raw-e0518131442f", "prefixes": [], "history": { "v1": [ "20240801-aref-into-raw-v1-1-33401e2fbac8@google.com" ] } } }
Sending a v2 that is merged with [1]. I didn't realize that I was duplicating work, sorry! I'll update the author information to list Kartik as the primary author. I kept my function body so that it returns NonNull to mirror the type used by `ARef::from_raw`. This change was previously included in https://lore.kernel.org/all/20240801-vma-v3-1-db6c1c0afda9@google.com/ but is being split out in its own commit at Danilo's suggestion. To: Miguel Ojeda <ojeda@kernel.org> Cc: Alex Gaynor <alex.gaynor@gmail.com> Cc: Wedson Almeida Filho <wedsonaf@gmail.com> Cc: Boqun Feng <boqun.feng@gmail.com> Cc: Gary Guo <gary@garyguo.net> Cc: Björn Roy Baron <bjorn3_gh@protonmail.com> Cc: Benno Lossin <benno.lossin@proton.me> Cc: Andreas Hindborg <a.hindborg@samsung.com> Cc: Andreas Hindborg <a.hindborg@samsung.com> Cc: rust-for-linux@vger.kernel.org Cc: linux-kernel@vger.kernel.org Link: Rust-for-Linux#1056 [1] Signed-off-by: Alice Ryhl <aliceryhl@google.com> --- Changes in v3: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v2: https://lore.kernel.org/r/20240821-aref-into-raw-v2-1-9215bbca5720@google.com Changes in v2: - Add example from [1], and fix the imports in the example so it compiles. - Update author information to reflect merge with [1]. - Link to v1: https://lore.kernel.org/r/20240801-aref-into-raw-v1-1-33401e2fbac8@google.com --- b4-submit-tracking --- # This section is used internally by b4 prep for tracking purposes. { "series": { "revision": 3, "change-id": "20240801-aref-into-raw-e0518131442f", "prefixes": [], "history": { "v1": [ "20240801-aref-into-raw-v1-1-33401e2fbac8@google.com" ], "v2": [ "20240821-aref-into-raw-v2-1-9215bbca5720@google.com" ] } } }
c9b5ce6 to
ce1c54f
Compare
9ee7197 to
6ce162a
Compare
f264495 to
f4daa80
Compare
eb6778a to
b20fbbc
Compare
5d132fa to
3b83f5d
Compare
Closes: #1044